Skip to content

remove_gauge_dependence! overloads#419

Merged
lkdvos merged 5 commits into
mainfrom
ld-gaugeremoval
May 12, 2026
Merged

remove_gauge_dependence! overloads#419
lkdvos merged 5 commits into
mainfrom
ld-gaugeremoval

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Apr 27, 2026

After MatrixAlgebraKit v0.6.6, these functions are now simply overloaded and the block implementation can be re-used

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/factorizations/pullbacks.jl 88.23% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/factorizations/pullbacks.jl 70.45% <88.23%> (+70.45%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos force-pushed the ld-gaugeremoval branch 2 times, most recently from 5572080 to 1990b05 Compare April 28, 2026 11:05
@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Apr 28, 2026

Needs QuantumKitHub/MatrixAlgebraKit.jl#221
Bypassed this by using default arguments

Comment thread src/factorizations/pullbacks.jl Outdated
@lkdvos lkdvos marked this pull request as ready for review April 28, 2026 14:23
@lkdvos lkdvos force-pushed the ld-gaugeremoval branch from bd17b3d to f30994b Compare May 9, 2026 20:41
@lkdvos lkdvos requested a review from Jutho May 11, 2026 16:41
@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented May 12, 2026

Fun fact, apparently the wording in the MatrixAlgebraKit linked PR auto closed this one ??

@Jutho
Copy link
Copy Markdown
Member

Jutho commented May 12, 2026

Ok, the argument composition of the remove_x_gauge_dependence functions is apparently quite inconsistent, which I did not realise. That is not very nice, but will unfortunately require yet another breaking update of MAK. Anyway, independent of this PR which looks good.

@lkdvos lkdvos merged commit aaa368c into main May 12, 2026
94 of 101 checks passed
@lkdvos lkdvos deleted the ld-gaugeremoval branch May 12, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants